Matches for patch, 1691 total results Sorted by newest | relevance
Sun Jan 24 08:13:55 UTC 2016 <phf> one of the features of the openbsd patch is that it should build cleanly on linux, i.e. naive build or a stator build. i did a naive build that work, while i was developing, but since i assume it was not included in stator i can't speak to that.
Sun Jan 24 08:07:21 UTC 2016 <BingoBoingo> If asciilifeform reads and tests what he signs the openbsd patch would have been missed. Timestamp may have been overlooked.
Sun Jan 24 07:59:46 UTC 2016 <mircea_popescu> i think the migration was done by patch authors rly.
Sun Jan 24 07:52:08 UTC 2016 <phf> when it was written and submitted it applied cleanly to the tree. to my knowledge it doesn't interfere with stator build. in fact the whole point of patch is to make minimally intrusive changes to source so that interested parties don't have to track down silly issues when attempting a build on their own. it's my understanding that the patch was simply dropped during v-ification, so of course now it doesn't in any way fits into
Sun Jan 24 07:52:07 UTC 2016 <phf> openbsd patch as written results in a working build on both linux and openbsd. it introduces necessary ifdefs to ensure cross platform support. the only change that it does to makefile is, at least according to my research, is necessary with some versions of gcc, rather then openbsd specific (has to do with static linking of pthread). without that change build ~can~ produce broken static bitcoind on both openbsd and linux. at the time
Sun Jan 24 02:29:03 UTC 2016 <mod6> and further, the changes that we wanted to make with V (where we mechanically check to see the patch was applied correctly by checking the hashes) also will not work on bsd unless a bunch more alterations are made, but this is a side issue.
Sun Jan 24 00:42:45 UTC 2016 <ben_vulpes> fwiw i completely failed to get the openbsd patch to work.
Sun Jan 24 00:40:43 UTC 2016 <mod6> phf: your patch(s) did work for me on openbsd. i think, once we have all of trinque's makefiles ready to go with the new (forthcoming) version of V, you and I should work together to get a new vpatch of your openbsd changes submitted.
Sat Jan 23 23:47:25 UTC 2016 <phf> but the patch got lost, between punkman taking over logging improvements and the v-ification
Sat Jan 23 23:46:11 UTC 2016 <mircea_popescu> is this in a patch ?
Sat Jan 23 15:44:48 UTC 2016 <asciilifeform> we aren't trying to minimize patch-line-counts AS SUCH
Sat Jan 23 15:44:14 UTC 2016 <asciilifeform> *patch
Sat Jan 23 15:44:03 UTC 2016 <asciilifeform> but ~in own patch~
Sat Jan 23 15:43:44 UTC 2016 <asciilifeform> mircea_popescu: my original thumbs-down for his patch was on account of bundling multiple-unlikes
Sat Jan 23 15:42:18 UTC 2016 <punkman> mircea_popescu: start over, meaning make a new debug_sanity patch with more improvements (and without the gui snipping parts bundled together)
Sat Jan 23 15:01:46 UTC 2016 <punkman> I'd like to contribute more debug-related patches, could maybe split the gui-snip stuff from debug_sanity patch, and start over.
Sat Jan 23 02:58:48 UTC 2016 <asciilifeform> also it appears that his version requires you to manually munge it every time a new patch is added
Fri Jan 22 15:53:00 UTC 2016 <*> ascii_butugychag goes to read the patch
Fri Jan 22 15:52:50 UTC 2016 <mircea_popescu> ok but aren't they intended to be functionally equivalent by the patch ?
Fri Jan 22 04:27:01 UTC 2016 <mod6> if you do a pull of that patch (be sure to obviously run dos2unix on it to get rid of CRLF), you should see that all of the lines in key.h:Sign() have tabs in front of them.